Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add conversation components to component metadata schema and bundle #3705

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

famarting
Copy link
Contributor

Description

Please explain the changes you've made

I realized of this because the metadata bundle included in the 1.15 release does not contain conversation components

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #[issue number]

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]

Sorry, something went wrong.

Signed-off-by: Fabian Martinez <46371672+famarting@users.noreply.github.com>
@famarting famarting requested review from a team as code owners March 14, 2025 16:52
yaron2
yaron2 previously approved these changes Mar 15, 2025
Signed-off-by: Fabian Martinez <46371672+famarting@users.noreply.github.com>
@yaron2
Copy link
Member

yaron2 commented Mar 31, 2025

Build is failing

Copy link
Contributor

@cicoyle cicoyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@famarting can you fix the linter issues?

@famarting
Copy link
Contributor Author

actually there are no linter issues, I think these are a couple of flaky tests that failed, can you retry the tests?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants